Fix MCP server test timeouts in safe_outputs_mcp_server_defaults #11368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three tests in
safe_outputs_mcp_server_defaults.test.cjswere timing out at 10 seconds because the MCP server process needed more time to initialize and respond before assertions ran.Changes
Applied to:
should have optional branch parameter for create_pull_requestshould have optional branch parameter for push_to_pull_request_branchshould return stringified JSON in text contentThe tests spawn a Node.js child process running the MCP server and communicate via stdin/stdout. The original delays were insufficient for the server to process
tools/listandtools/callrequests before the test checked for responses, resulting inundefinedvalues and timeout failures.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.